SNOW-1848242 + Send clientname and clientkey with every registerblobs request for metering views #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… used for emitting iceberg billing info
sfc-gh-xhuang
changed the title
src/main/java/net/snowflake/ingest/streaming/internal/InternalStage.java
Show resolved
Hide resolved
sfc-gh-xhuang
approved these changes
Dec 2, 2024
sfc-gh-alhuang
approved these changes
Dec 2, 2024
sfc-gh-hmadan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iceberg's billing needs the clientname and clientkey at the time of DML Commit. While it can be read via a S3 get-metadata call, its a wasteful approach. This PR optimizes away that S3 call by sending the metadata inline with the registerBlobs API call.
Ran FDN and Iceberg ITs locally against sfctest0 to make sure the json backcompat fix from months ago will allow unknown fields to appear on the payload without causing issues. IT run from this PR's merge gate should be green.